test: Make Browser.{focus,blur}() synchronous #19078
Closed
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling .focus() and .blur() is asynchronous. When followed by key presses (which is the common use case for foucssing), this sometimes leads to typing the key presses somewhere else than the intended focussed element. To fix that, wait until the active element actually switched to the desired one.
martinpitt
changed the title
|
Eww -- we call this with double-quotes, and more importantly with sizzle selectors, so that will need some more work. |
|
Also, it does not work in testPod yet either. |
This was referenced Jul 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling .focus() and .blur() is asynchronous. When followed by key presses (which is the common use case for foucssing), this sometimes leads to typing the key presses somewhere else than the intended focussed element. To fix that, wait until the active element actually switched to the desired one.
Should help with this failure, which produces this lovely mess. I'll test that in cockpit-project/cockpit-podman#1324